[rekonq] Review Request: Make load clipboard URL on middle-click optional

Johannes Tröscher fritz_van_tom at hotmail.com
Tue Sep 20 18:36:37 UTC 2011



> On Sept. 20, 2011, 8:17 a.m., Andrea Diamantini wrote:
> > if you two are ok with this, I'm with you. I'd like just to point out string freeze WAS tomorrow :) and we need to merge this ASAP, as I have not yet branched 0.8 code. (where ASAP means today or after 0.8 release).
> 
> Johannes Tröscher wrote:
>     i'm ok with it. i haven't tested it, but the code looks good and i'm sure Furkan won't post it without trying it ;)
>     pls merge
>     
>     ps: maybe add an enum for the options in the futuren
> 
> Furkan Üzümcü wrote:
>     Yes, I did test it. But If you have a couple of hours, I can test it again, just in case. Otherwise the path is already ok.
> 
> Furkan Üzümcü wrote:
>     The patch works just fine.

yeah, please merge


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102647/#review6655
-----------------------------------------------------------


On Sept. 19, 2011, 7:48 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102647/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 7:48 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Title says everything. Also, I do think this feature is better when optional.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg b583aa8 
>   src/settings/settings_appearance.ui b81d23f 
>   src/webview.cpp 3da044e 
> 
> Diff: http://git.reviewboard.kde.org/r/102647/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110920/4e50adeb/attachment.html>


More information about the rekonq mailing list