[rekonq] Review Request: search with defaultEngine in errorpage

Johannes Tröscher fritz_van_tom at hotmail.com
Thu Sep 15 08:40:02 UTC 2011



> On Sept. 13, 2011, 8:51 a.m., Andrea Diamantini wrote:
> > src/webpage.cpp, line 669
> > <http://git.reviewboard.kde.org/r/102592/diff/1/?file=35975#file35975line669>
> >
> >     uhm, probably you need i18n("Search with %1", ... here.
> 
> Andrea Diamantini wrote:
>     PS: this is 0.9 material, isn't it?

don't know, the patch is very small, but it's up to you.


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102592/#review6471
-----------------------------------------------------------


On Sept. 15, 2011, 8:30 a.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102592/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 8:30 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> adds a link to search with default search engine to the errorpage
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp 1119d4b 
> 
> Diff: http://git.reviewboard.kde.org/r/102592/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110915/0d252ed6/attachment.html>


More information about the rekonq mailing list