[rekonq] Review Request: Change the "Paste & Go" action's text to "Paste & Search" if the content of the clipboard is not a URL

Andrea Diamantini adjam7 at gmail.com
Thu Sep 8 03:49:46 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102441/#review6324
-----------------------------------------------------------


I tested this and I noticed it really doesn't work. Let me explain: the changes proposed work very well, but trying to "paste & search" something it really is NOT searched on the web. I really think this should be fixed on the pasteAndGo() method.

- Andrea


On Sept. 4, 2011, 2:04 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102441/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 2:04 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If the content of the clipboard is not a URL, the "Paste & Go" action's text is changed to "Paste & Search".
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.h 7059725 
>   src/urlbar/urlbar.cpp 04d9698 
> 
> Diff: http://git.reviewboard.kde.org/r/102441/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110908/10ba194c/attachment.html>


More information about the rekonq mailing list