[rekonq] Review Request: Enable dropping urls or text on tabbar to open them in new tab(s)
Andrea Diamantini
adjam7 at gmail.com
Fri Oct 21 15:22:51 UTC 2011
> On Oct. 20, 2011, 8:11 p.m., Andrea Diamantini wrote:
> > Excuse me, but... before merge... Can you explain me why you are not simply using QUrl::isValid() method?
>
> Furkan Üzümcü wrote:
> QUrl::isValid() method doesn't really work as it should. Thiago Macieira explains the reason better in this blog post. --> http://www.macieira.org/blog/2011/10/qurl-in-qt-5-validity/
Ok, sorry for the noise. Merging your patch.
- Andrea
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102811/#review7516
-----------------------------------------------------------
On Oct. 19, 2011, 5:12 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102811/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2011, 5:12 p.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> With this patch you can drop a URL(s) on the tabbar to open it in new tab(s) or text to search it.
>
>
> Diffs
> -----
>
> src/tabbar.h b4c816b
> src/tabbar.cpp ea01ef9
>
> Diff: http://git.reviewboard.kde.org/r/102811/diff/diff
>
>
> Testing
> -------
>
> Compiles and works.
>
>
> Thanks,
>
> Furkan Üzümcü
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111021/ddf1b2bc/attachment.html>
More information about the rekonq
mailing list