[rekonq] Review Request: Enable dropping urls or text on tabbar to open them in new tab(s)

[Furkan Üzümcü]

> On Oct. 19, 2011, 3:59 p.m., Andrea Diamantini wrote:
> > src/tabbar.h, line 107
> > <http://git.reviewboard.kde.org/r/102811/diff/4/?file=38482#file38482line107>
> >
> >     This has to be "bool isValidUrl(const QString &url)"
> 
> Andrea Diamantini wrote:
>     and obviously the implementation has to be fixed accordingly. After this, everything seems ready for merge :)

But I edit "url" inside the function. Why has it to be that way?


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102811/#review7492
-----------------------------------------------------------


On Oct. 10, 2011, 1:47 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102811/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2011, 1:47 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> With this patch you can drop a URL(s) on the tabbar to open it in new tab(s) or text to search it.
> 
> 
> Diffs
> -----
> 
>   src/tabbar.h b4c816b 
>   src/tabbar.cpp ea01ef9 
> 
> Diff: http://git.reviewboard.kde.org/r/102811/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan Üzümcü
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111019/2d1cc48d/attachment.html>