[rekonq] Review Request: Add AdBlock icon on the UrlBar to inform the user that some content was hidden due to AdBlock

Andrea Diamantini adjam7 at gmail.com
Wed Oct 19 15:06:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102761/#review7488
-----------------------------------------------------------


I really like this new information added, but I'd like to show a new dialog from the adblock icon in the urlbar, to let people decide what elements can be shown and what (local) rules can be added to the adblock. What do you guys think about? 

- Andrea Diamantini


On Oct. 3, 2011, 10:26 a.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102761/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2011, 10:26 a.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> With this patch the user will be informed whenever some content was filtered out by AdBlock.
> The icon on the UrlBar gives fast access to AdBlock settings as well.
> 
> 
> Diffs
> -----
> 
>   src/adblock/adblockmanager.cpp 7c0b94f 
>   src/networkaccessmanager.cpp 21377dd 
>   src/urlbar/urlbar.h a9ce301 
>   src/urlbar/urlbar.cpp 0515f58 
>   src/webpage.h 8e12364 
>   src/webpage.cpp a7523c1 
>   src/webtab.h 5700ba7 
>   src/webtab.cpp 61c9077 
> 
> Diff: http://git.reviewboard.kde.org/r/102761/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and working.
> 
> 
> Thanks,
> 
> Andrea Di Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111019/82619a1e/attachment.html>


More information about the rekonq mailing list