[rekonq] Review Request: Pinning Tab Feature

Furkan Üzümcü furkanuzumcu at gmail.com
Thu Oct 13 14:47:48 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102839/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

This feature has become a "must have" for any browser. So I thought I could do something about it. The patch works fine except a few glitches which I'm hoping you can help me about. I do believe this patch isn't perfect. So please help me improve it.
There are 2 problems.
1- Open 2 tabs. While on the first tab pin the second one. And you'll se the problem. This is the best way to tell you.
2- Icons aren't shown right after pinning a tab.


Diffs
-----

  src/application.cpp 6f9df43 
  src/mainview.cpp 0cd61dd 
  src/rekonq.kcfg d29a5a3 
  src/tabbar.h b4c816b 
  src/tabbar.cpp ea01ef9 

Diff: http://git.reviewboard.kde.org/r/102839/diff/diff


Testing
-------

Compiles and works except some glitches.


Thanks,

Furkan Üzümcü

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111013/3576f52e/attachment.html>


More information about the rekonq mailing list