[rekonq] Review Request: Change document url to KParts Document's url when saving

[Andrea Di Menna]

> On Oct. 4, 2011, 10:03 a.m., Andrea Diamantini wrote:
> > Did you test it just with "view source" katepart? Because rekonq seems working well eg with okularpart, but not with katepart. I'd like to understand this before merging such change.

Yes I have tested also with okularpart.
It keeps working because in that case the part url is the same as the webtab url (remote URL and not the local temp file URL).


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102768/#review7072
-----------------------------------------------------------


On Oct. 4, 2011, 7:47 a.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102768/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 7:47 a.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> When the Save As action is invoked on a KParts document (e.g. view source katepart) the WebTab's url is used to:
> 1) set the filename in KFileDialog
> 2) set the src url for the kio copy job
> 
> The url is empty in such cases and the save action fails.
> 
> I have changed the srcUrl to be the url set for the KParts document.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 528ec21 
> 
> Diff: http://git.reviewboard.kde.org/r/102768/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and working
> 
> 
> Thanks,
> 
> Andrea Di Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111004/02f3651e/attachment.html>