[rekonq] Review Request: GCI Task : Don't open useless tabs for actions in the new tab page with mid click

Yoann Laissus yoann.laissus at gmail.com
Mon Nov 28 08:51:18 UTC 2011



> On Nov. 27, 2011, 11:24 a.m., Andrea Diamantini wrote:
> > I don't think this is a "proper" solution. We should probably try to let mid-click work as normal ones. Or at least, well comment that strange piece of code... ;)

I agree with you, mid click should behave as a normal click. My description in melange wasn't clear enough :D
I will fix and commit that today.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103257/#review8507
-----------------------------------------------------------


On Nov. 26, 2011, 4:53 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103257/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 4:53 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Patch by Hüseyin Zengin, GCI student.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 6ef0b0c 
> 
> Diff: http://git.reviewboard.kde.org/r/103257/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111128/f0b6ab47/attachment-0001.html>


More information about the rekonq mailing list