[rekonq] Review Request: GCI Task: Add a Shortcut to Open Downloads Page

[Andrea Diamantini]

> On Nov. 23, 2011, 4:38 p.m., Andrea Diamantini wrote:
> > You are just adding the action, you (him?) are not interested in showing it somewhere. Is this correct?
> 
> Andrea Diamantini wrote:
>     Please, read again this comment. Current code does NOT show the action anywhere but in the actionCollection (hence in the toolbar configuration dialog). Is this wanted?
> 
> Furkan Üzümcü wrote:
>     I'm so sorry for the delay. I'm in the exam week and barely have time. Yes it is wanted.

Ok Furkan, sorry for the noise. Merging the patch...

PS: Good luck for your exams.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103207/#review8413
-----------------------------------------------------------


On Nov. 23, 2011, 5:39 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103207/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 5:39 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> This is a Google Code-in 2011 task. Made by Ömer Faruk Oruç, GCI student.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 9dfe4a1 
>   src/mainwindow.cpp 811f1cf 
> 
> Diff: http://git.reviewboard.kde.org/r/103207/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan Üzümcü
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111127/b7ab0604/attachment.html>