[rekonq] Review Request: refactor UA code and menu (to be in the same shape as Konqueror)

[Andrea Diamantini]

> On Nov. 25, 2011, 9:43 a.m., Johannes Tröscher wrote:
> > src/useragent/useragentmanager.h, line 56
> > <http://git.reviewboard.kde.org/r/103230/diff/1/?file=41923#file41923line56>
> >
> >     maybe we should come to an agreement how to name members as some of the devs always use m_memberName and others _memberName

yes, as always in these cases it's my fault. I started with the "m_" convention and then changed my mind. Easier to correct new patches back and change my mind again :)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103230/#review8461
-----------------------------------------------------------


On Nov. 24, 2011, 5:09 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103230/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2011, 5:09 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Title says it all.
> Two commits in this patch:
> 1) refactor UA code, adding a userAgentManager to better split out ua code.
> 2) refactor UA menu, to be in the same shape as konqueror
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ced397c 
>   src/application.h acc0335 
>   src/application.cpp f37720f 
>   src/mainwindow.h 9dfe4a1 
>   src/mainwindow.cpp c53fcb6 
>   src/useragent/useragentinfo.h 417aeea 
>   src/useragent/useragentinfo.cpp 0829a7e 
>   src/useragent/useragentmanager.h PRE-CREATION 
>   src/useragent/useragentmanager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103230/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new UA menu
>   http://git.reviewboard.kde.org/r/103230/s/344/
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111125/e48a5312/attachment.html>