[rekonq] Review Request: refactor UA code and menu (to be in the same shape as Konqueror)

Andrea Diamantini adjam7 at gmail.com
Thu Nov 24 17:09:46 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103230/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

Title says it all.
Two commits in this patch:
1) refactor UA code, adding a userAgentManager to better split out ua code.
2) refactor UA menu, to be in the same shape as konqueror


Diffs
-----

  src/CMakeLists.txt ced397c 
  src/application.h acc0335 
  src/application.cpp f37720f 
  src/mainwindow.h 9dfe4a1 
  src/mainwindow.cpp c53fcb6 
  src/useragent/useragentinfo.h 417aeea 
  src/useragent/useragentinfo.cpp 0829a7e 
  src/useragent/useragentmanager.h PRE-CREATION 
  src/useragent/useragentmanager.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103230/diff/diff


Testing
-------


Screenshots
-----------

new UA menu
  http://git.reviewboard.kde.org/r/103230/s/344/


Thanks,

Andrea Diamantini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111124/977da656/attachment.html>


More information about the rekonq mailing list