[rekonq] Review Request: GCI Task: Middle Click a Bookmark Folder to Open Folder in New Tabs
Yoann Laissus
yoann.laissus at gmail.com
Tue Nov 22 18:27:55 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103206/#review8397
-----------------------------------------------------------
This event filter is complex enough :D
I think it's better to group at the same place all the things related to a click on a KBookarkAction*
So, this patch needs to be integrated in this big if (in the MouseReleaseEvent) :
509 if (watched != toolBar() && mouseEvent && mouseEvent->button() != Qt::MidButton)
- Yoann Laissus
On Nov. 22, 2011, 6:02 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103206/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2011, 6:02 p.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> This is a Google Code-in 2011 task. Made by Hüseyin Zengin, GCI student.
>
>
> Diffs
> -----
>
> src/bookmarks/bookmarkstoolbar.cpp 23af65c
>
> Diff: http://git.reviewboard.kde.org/r/103206/diff/diff
>
>
> Testing
> -------
>
> Compiles and works.
>
>
> Thanks,
>
> Furkan Üzümcü
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111122/65ca2eaa/attachment.html>
More information about the rekonq
mailing list