[rekonq] Review Request: Use the title instead of url when adding application shortcuts
Johannes Tröscher
fritz_van_tom at hotmail.com
Tue Nov 8 22:55:17 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103086/#review8035
-----------------------------------------------------------
using the title would really be better :)
src/application.cpp
<http://git.reviewboard.kde.org/r/103086/#comment6918>
title could be a const string
- Johannes Tröscher
On Nov. 8, 2011, 10:47 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103086/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2011, 10:47 p.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> When we add an application shortcut, the shortcut's name is the URL of the web app which doesn't look good. So I think having the titles of the web apps is a better way.
>
>
> Diffs
> -----
>
> src/application.cpp d29324c
>
> Diff: http://git.reviewboard.kde.org/r/103086/diff/diff
>
>
> Testing
> -------
>
> Compiles and works.
>
>
> Thanks,
>
> Furkan Üzümcü
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111108/2a562ca9/attachment.html>
More information about the rekonq
mailing list