[rekonq] Re: Review Request: Updates session file before last window is closed

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101346/#review3372
-----------------------------------------------------------



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101346/#comment2807>

    It's not that obvious here that the signal is emitted while the last window is closing.
    It needs a comment or (better?) to be moved in app dtor, IMHO.


- Andrea


On May 12, 2011, 10:25 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101346/
> -----------------------------------------------------------
> 
> (Updated May 12, 2011, 10:25 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Earlier, when a user had two windows open, and closed one of them, it was not removed from the session file unless some new tab activity happened. This tab ensures that the session file is updated before the last open window is closed. This will cause all unsaved changes to be saved at the last moment.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 9853ca3 
>   src/mainwindow.cpp f226c9e 
> 
> Diff: http://git.reviewboard.kde.org/r/101346/diff
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110517/3e8dfd48/attachment.htm