[rekonq] Re: Review Request: Remembers the order of tabs properly in the session-file.

[Tirtha Chatterjee]

> On May 12, 2011, 9:49 p.m., Andrea Diamantini wrote:
> > src/tabbar.cpp, line 310
> > <http://git.reviewboard.kde.org/r/101339/diff/1/?file=16343#file16343line310>
> >
> >     Can you explain a bit the delayed shot choice?

QTabWidget (and hence, MainView) uses the tabMoved signal to understand when a tab rearrange has occured, and changes the tab order accordingly. Since we are also using the same signal, so if we don't use timer, the changes in MainView will not yet have taken place when the session is being stored to the file. So we wait for 200 miliseconds for the MainView to rearrange its tabs using the tabMoved signal, then save it.

I am not sure that I could make myself clear ;)


- Tirtha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101339/#review3285
-----------------------------------------------------------


On May 11, 2011, 11:08 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101339/
> -----------------------------------------------------------
> 
> (Updated May 11, 2011, 11:08 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> connects tabMoved signal of TabBar to tabsChanged signal of MainView, so any changes in tab order due to dragging tabs are saved in the sessions file using SessionManager. So now the changes in the order of tabs is correctly remembered during restore.
> 
> 
> Diffs
> -----
> 
>   src/tabbar.h c7bf88e 
>   src/tabbar.cpp 1ab357f 
> 
> Diff: http://git.reviewboard.kde.org/r/101339/diff
> 
> 
> Testing
> -------
> 
> Tested and works.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110512/f7c0449d/attachment-0001.htm