[rekonq] Re: Review Request: Use more standard colors

Andrea Diamantini adjam7 at gmail.com
Mon Mar 21 22:48:57 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100908/#review2088
-----------------------------------------------------------

Ship it!


Sounds good!

- Andrea


On March 21, 2011, 8:40 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100908/
> -----------------------------------------------------------
> 
> (Updated March 21, 2011, 8:40 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch makes rekonq use standard colors for the https yellow and the colors of the find bar. This helps rekonq to integrate into other color schemes and prevents unreadable lines with dark color schemes. I didn't find anything for private browsing, so this had to stay hardcoded.
> 
> If you don't think this is a fix just leave it here until rekonq gets unfreezed again.
> 
> 
> This addresses bug 256535.
>     /show_bug.cgi?id=256535
> 
> 
> Diffs
> -----
> 
>   src/findbar.cpp ebb6e64 
>   src/urlbar/urlbar.cpp 8f3e11e 
> 
> Diff: http://git.reviewboard.kde.org/r/100908/diff
> 
> 
> Testing
> -------
> 
> Tested with Obsidian Coast color scheme
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110321/c69d411f/attachment.htm 


More information about the rekonq mailing list