[rekonq] Re: Review Request: Refresh all "about:bookmarks" pages when bookmarks are updated

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100895/#review2074
-----------------------------------------------------------


No please, this cannot be the solution. (Moreover, it removes the mainWindow checks and it can be crashy). 
Cannot we think to add a refresh signal to the newtabpage mechanism to just trigger from there?

- Andrea


On March 20, 2011, 5:27 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100895/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 5:27 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Refresh all "about:bookmarks" pages when bookmarks are updated
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.cpp 9049c30 
> 
> Diff: http://git.reviewboard.kde.org/r/100895/diff
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110321/c1e8cbe4/attachment.htm