[rekonq] Re: Review Request: Add a hidden option to disable the tab highlight effect

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100863/#review1985
-----------------------------------------------------------


Sorry again for my stupid error...
Anyway I think we don't need here an "hidden" option, because we should let people disable this quite easily if they yet have problems with. So, I vote for a "shown option", with a checkbox in the tabs dialog and its settings updated in the updateConfiguration slot.

- Andrea


On March 15, 2011, 12:35 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100863/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 12:35 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This is a workaround for bug 267234. Disabling the effect seems to prevent the bug from happening. As it's no fun to use and test rekonq-git while this bug exists, I'd like to see this workaround in rekonq until the bug is fixed.
> 
> 
> This addresses bug 267234.
>     /show_bug.cgi?id=267234
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg 8795104 
>   src/tabhighlighteffect.cpp b2d1e0d 
> 
> Diff: http://git.reviewboard.kde.org/r/100863/diff
> 
> 
> Testing
> -------
> 
> Tried to reproduce the bug for half an hour, it didn't occur anymore.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110315/b84e8660/attachment.htm