[rekonq] Re: Review Request: Add a hidden option to disable the tab highlight effect

[Andrea Diamantini]

> On March 15, 2011, 2:21 p.m., Andrea Diamantini wrote:
> > src/tabhighlighteffect.cpp, line 49
> > <http://git.reviewboard.kde.org/r/100863/diff/1/?file=11435#file11435line49>
> >
> >     I cannot understand how can, disabling the whole tabbar, help in any way...
> 
> Felix Rohrbach wrote:
>     I don't understand what you mean. I just disable the effect, not the tabbar.
> 
> Andrea Diamantini wrote:
>     If I can read your code well you wrote: 
>     if (! Rekonfig::useTabEffects() )
>         setEnabled(false)
>     
>     NOT
>     
>     m_graphicsEffects -> setEnabled(false)
>     
>     You are launching "this->setEnabled(false)", the tabbar, hence the effect, the mouse, the keyboard... everything against the tabbar.
>
> 
> Felix Rohrbach wrote:
>     As I wrote the code in the effect class, "this" points to the effect, not to the tab bar.

As you wrote in the TabHighLightsEffect class, it seems I need a new pair of glasses... :)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100863/#review1966
-----------------------------------------------------------


On March 15, 2011, 12:35 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100863/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 12:35 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This is a workaround for bug 267234. Disabling the effect seems to prevent the bug from happening. As it's no fun to use and test rekonq-git while this bug exists, I'd like to see this workaround in rekonq until the bug is fixed.
> 
> 
> This addresses bug 267234.
>     /show_bug.cgi?id=267234
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg 8795104 
>   src/tabhighlighteffect.cpp b2d1e0d 
> 
> Diff: http://git.reviewboard.kde.org/r/100863/diff
> 
> 
> Testing
> -------
> 
> Tried to reproduce the bug for half an hour, it didn't occur anymore.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110315/f67c64b3/attachment.htm