[rekonq] Re: stop loading page on esc key

[Rohan Garg]

Hi
Now the issue is that the escape key shortcut is used for stopping the
suggestions from the urlbar, so if you set the escape shortcut to stop
the webpage from loading, it breaks the urlbar.

Regards
Rohan Garg



On Sat, Mar 12, 2011 at 5:16 AM, burak alkan <mburakalkan at gmail.com> wrote:
> You are right, this is what I should have done in the first place, please
> discard first patch
>
> On 11 March 2011 06:55, Rohan Garg <rohangarg at ubuntu.com> wrote:
>>
>> Hi Burak
>> One of the issues i see is that the shortcut is not added to the
>> shortcuts tab in the configure rekonq section.There the shortcut is
>> still listed as : Ctrl + .
>>
>> Regards
>> Rohan Garg
>>
>>
>>
>> On Fri, Mar 11, 2011 at 4:35 AM, burak alkan <mburakalkan at gmail.com>
>> wrote:
>> > Hello,
>> > trigger stop action on esc key
>> >
>> > From 790d82a35fc61968ab9f433e7646e986e512db98 Mon Sep 17 00:00:00 2001
>> > From: Burak Alkan <mburakalkan at gmail.com>
>> > Date: Fri, 11 Mar 2011 00:38:03 +0200
>> > Subject: [PATCH] on escape key stop loading current tab
>> > ---
>> >  src/mainwindow.cpp |    9 +++++++++
>> >  src/mainwindow.h   |    1 +
>> >  2 files changed, 10 insertions(+), 0 deletions(-)
>> > diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
>> > index 34587b1..c877f66 100644
>> > --- a/src/mainwindow.cpp
>> > +++ b/src/mainwindow.cpp
>> > @@ -291,6 +291,9 @@ void MainWindow::postLaunch()
>> >      connect(this, SIGNAL(ctrlTabPressed()), m_view, SLOT(nextTab()));
>> >      connect(this, SIGNAL(shiftCtrlTabPressed()), m_view,
>> > SLOT(previousTab()));
>> >
>> > +    // escape key
>> > +    connect(this, SIGNAL(escapePressed()), m_view, SLOT(webStop()));
>> > +
>> >      // wheel history navigation
>> >      connect(m_view, SIGNAL(openPreviousInHistory()), this,
>> > SLOT(openPrevious()));
>> >      connect(m_view, SIGNAL(openNextInHistory()), this,
>> > SLOT(openNext()));
>> > @@ -1072,6 +1075,12 @@ void MainWindow::keyPressEvent(QKeyEvent *event)
>> >          return;
>> >      }
>> >
>> > +    if (event->key() == Qt::Key_Escape)
>> > +    {
>> > +        emit escapePressed();
>> > +        return;
>> > +    }
>> > +
>> >      KMainWindow::keyPressEvent(event);
>> >  }
>> >
>> > diff --git a/src/mainwindow.h b/src/mainwindow.h
>> > index 6c2c12b..fe0886c 100644
>> > --- a/src/mainwindow.h
>> > +++ b/src/mainwindow.h
>> > @@ -124,6 +124,7 @@ Q_SIGNALS:
>> >
>> >      void triggerPartPrint();
>> >      void triggerPartFind();
>> > +    void escapePressed();
>> >
>> >  protected Q_SLOTS:
>> >      void saveNewToolbarConfig();
>> > --
>> > 1.6.4.2
>> >
>> > _______________________________________________
>> > rekonq mailing list
>> > rekonq at kde.org
>> > https://mail.kde.org/mailman/listinfo/rekonq
>> >
>> >
>
>