[rekonq] Re: Review Request: notifyPopup improvements

[Pierre Rossi]

> On July 28, 2011, 8:43 a.m., Andrea Diamantini wrote:
> > src/mainwindow.cpp, line 1231
> > <http://git.reviewboard.kde.org/r/102105/diff/1/?file=30115#file30115line1231>
> >
> >     Can you pls add a comment here explaining what it is happening?

To be fair that code was there before, the diff just makes it look new for some reason. I only wonder if there's a reason not to make it const. ;)


> On July 28, 2011, 8:43 a.m., Andrea Diamantini wrote:
> > src/mainwindow.cpp, line 1177
> > <http://git.reviewboard.kde.org/r/102105/diff/1/?file=30115#file30115line1177>
> >
> >     Is there a reason because you removed this?

I think the answer's in the description: "this makes possible, that you can view url-previews if the window is not the active one and you hover a link"


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102105/#review5151
-----------------------------------------------------------


On July 27, 2011, 8:32 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102105/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 8:32 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> this patch changes two things in the notifypopup:
> first: it uses a QLabel that is drawn inside the window, instead of a KPassivePopup
> this makes possible, that you can view url-previews if the window is not the active one and you hover a link
> 
> second: it limits the size of the url-preview to the half size of the browser-screen like in firefox4.
> (it's a question of taste, i like it :D )
> 
> ......
> third: i think the code is a bit easier to read :)
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h e7a5207 
>   src/mainwindow.cpp d0d4d40 
> 
> Diff: http://git.reviewboard.kde.org/r/102105/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110728/e79a5a0f/attachment.htm