[rekonq] Re: Review Request: use KPart to view page source

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102085/#review5094
-----------------------------------------------------------


While in general I'd like and prefer kparts use to show source code, I see an important issue in your code: the url has to be loaded twice, letting the first part of the function being unuseful. I'd like this patch to solve this: load saved url inside kparts.

- Andrea


On July 25, 2011, 4:38 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102085/
> -----------------------------------------------------------
> 
> (Updated July 25, 2011, 4:38 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> show source using kparts
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp e4bddd1 
> 
> Diff: http://git.reviewboard.kde.org/r/102085/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> one minor issue: path of the temporary file is shown in titlebar.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102085/s/212/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110725/990a3d8c/attachment.htm