[rekonq] Re: Review Request: Fallback to homepage if restoring of session failed

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102064/#review5009
-----------------------------------------------------------

Ship it!


LGTM. Never sure about these coding style issues since we tend to go by a few weird rules... ;)


src/application.cpp
<http://git.reviewboard.kde.org/r/102064/#comment4441>

    I wouldn't put braces for the single line statement, need to check the peculiarities of the rekonq coding style (by those standards the opening brace should be on a new line down below btw, which I'm personally not a big fan of)


- Pierre


On July 23, 2011, 7:51 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102064/
> -----------------------------------------------------------
> 
> (Updated July 23, 2011, 7:51 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If restoring a session failed for some reason (session-file missing, incorrect format, etc.) then Rekonq should be able to fall back to opening the home page of the user. Right now, it crashes in some cases if restoration did not happen properly.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 8bca4f6 
> 
> Diff: http://git.reviewboard.kde.org/r/102064/diff
> 
> 
> Testing
> -------
> 
> Yes. Works fine here.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110723/09caf3a8/attachment.htm