[rekonq] Review Request: Introducing ASSERT_NOT_REACHED.

Pierre Rossi pierre.rossi at gmail.com
Thu Jul 21 22:58:01 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102041/
-----------------------------------------------------------

Review request for rekonq and Andrea Diamantini.


Summary
-------

This is following the comments in https://git.reviewboard.kde.org/r/101945/

In a similar fashion as WebKit, this might make those cases
where we don't expect to go more obvious in debug builds.
I also took the liberty to revisit a lot of switch statements
but it could potentially be used elsewhere.


Diffs
-----

  src/application.cpp 8bca4f63f138a4310b7b0db3948f85b6e6fa5569 
  src/bookmarks/bookmarkowner.cpp 75b5f12d1bdadd4ff2ec6233272e4d9ba3c26910 
  src/history/historymanager.cpp 3b765e7dbc23a753358fd5fa177517d7a4331121 
  src/mainwindow.cpp e4bddd1a65613f3b7c6c63b0a8a14a7cf816d214 
  src/rekonq_defines.h fd0d1e257410e26a4c616baee4b62d1bd0f6429e 
  src/urlbar/urlbar.cpp 37c085e6e6f55633c2837e0978e47f243af6d6c4 
  src/webpage.cpp 0c9b436df50408984d249ea8aaee740859ded152 
  src/webpluginfactory.cpp 9fe800753dcb715c327dc7af9684b1e761b2d60a 

Diff: http://git.reviewboard.kde.org/r/102041/diff


Testing
-------


Thanks,

Pierre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110721/6a84f722/attachment.htm 


More information about the rekonq mailing list