[rekonq] Re: Review Request: Added UI option to configure the new "Do Not Track" feature, available in the upcoming KDE SC 4.7
Pierre Rossi
pierre.rossi at gmail.com
Wed Jul 20 23:47:35 CEST 2011
> On July 19, 2011, 6:20 p.m., Pierre Rossi wrote:
> > src/settings/generalwidget.cpp, line 68
> > <http://git.reviewboard.kde.org/r/102010/diff/1/?file=27506#file27506line68>
> >
> > and maybe the "---..." can go ?
>
> Andrea Diamantini wrote:
> Sorry Pierre, you may have noticed I usually (k)Debug quite everything to not start everytime a gdb session ;)
> Time for some kDebug polish...
yeah I know, I tend to do a lot of that too, but too often take everything out.
Now since kDebug is pretty powerful with kdebugdialog, I think we should probably look into getting some reserved logging channels for different components in rekonq (fire kdebugdialog and look at how many say KIO has). I don't know who to talk to to get some of those for ourselves, but I'd be up for some sorting work on the debug output, I guess we'd gain a lot from it when investigating bugs.
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102010/#review4861
-----------------------------------------------------------
On July 19, 2011, 4:37 p.m., Andrea Diamantini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102010/
> -----------------------------------------------------------
>
> (Updated July 19, 2011, 4:37 p.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> Title says it all. Easy and safe, I hope.
>
>
> Diffs
> -----
>
> src/rekonq.kcfg dba770b
> src/settings/generalwidget.cpp 9f6de0d
> src/settings/settings_general.ui 0b27dab
>
> Diff: http://git.reviewboard.kde.org/r/102010/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110720/1b752ea9/attachment.htm
More information about the rekonq
mailing list