[rekonq] Re: Review Request: Add favorite with 2 clicks in the bookmark icon

[Andrea Diamantini]

> On July 19, 2011, 11:49 p.m., Pierre Rossi wrote:
> > src/urlbar/favoritewidget.cpp, line 121
> > <http://git.reviewboard.kde.org/r/101945/diff/1-2/?file=27019#file27019line121>
> >
> >     missing the space between "if" and '('
> >     
> >     Actually I noticed You have a *lot* of changes like these, way more than reasonable for just a patch update. Could it be your IDE trying to be a smart ass or something ?

I did a round of astyle and it did it. Maybe I need to search the option to fix that. Generally speaking, as IDE/editor I use a mix of vim/kate. And I understood kate IS the responsible for the "leading spaces" problem. So I decided to do a(nother) round of astyle before pushing the patch.
I guess the if-space problem will be fixed as soon as I'll find the right (new) astyle option :)


> On July 19, 2011, 11:49 p.m., Pierre Rossi wrote:
> > src/urlbar/urlbar.h, line 58
> > <http://git.reviewboard.kde.org/r/101945/diff/1-2/?file=27020#file27020line58>
> >
> >     that's still something I don't get... Since we're not a library, we could be using the "good looking" keywords, why use the not so nice Q_* macros instead ?

uhm.. I read about in techbase... a comment from someone saying: if you start using the Q_ macros style, you'll never be wrong. And I started, just that.


> On July 19, 2011, 11:49 p.m., Pierre Rossi wrote:
> > src/urlbar/urlbar.h, line 114
> > <http://git.reviewboard.kde.org/r/101945/diff/1-2/?file=27020#file27020line114>
> >
> >     better function naming ? bookmarkContextMenu maybe.

sure ;)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101945/#review4879
-----------------------------------------------------------


On July 18, 2011, 8:12 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101945/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 8:12 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Provide a "click" mechanism to manage favorites
>     
> With this commit, you can add a favorite by clicking 2 times in the bookmark icon.
> If an URL is a favorite, the favorite icon appears and then you can manage it from there...
> 
> Pushed on remote branch: AddFavoriteWithAClick
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt fd94616 
>   src/urlbar/favoritewidget.h PRE-CREATION 
>   src/urlbar/favoritewidget.cpp PRE-CREATION 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp ea60f47 
> 
> Diff: http://git.reviewboard.kde.org/r/101945/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110720/ce75239b/attachment.htm