[rekonq] Re: Review Request: improve appearance of urlbar's bookmarkwidget

[Pierre Rossi]

> On July 18, 2011, 5:41 p.m., Pierre Rossi wrote:
> > It seems it's been there since the beginning (1ed00f99), but I agree it does look very weird.
> 
> Furkan Üzümcü wrote:
>     I think "before" looks better. There is no need to align them to any corners, IMHO. It looks better at the center.

Even if we wanted things centered, I think the existing code is shaky for that, what if the translation for "Name:" is super long and the title and text on the pushbutton are long as well (compared to the icon and widget's size) ? then the top stuff will be right aligned with the current layout strategy. 


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102000/#review4821
-----------------------------------------------------------


On July 18, 2011, 5:29 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102000/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 5:29 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> improve appearance of the urlbar's bookmarkwidget.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/bookmarkwidget.cpp 811e89b 
> 
> Diff: http://git.reviewboard.kde.org/r/102000/diff
> 
> 
> Testing
> -------
> 
> compiles, tested, works, looks good :D
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102000/s/207/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110719/0f6d7c7e/attachment.htm