[rekonq] Re: Review Request: Added UI option to configure the new "Do Not Track" feature, available in the upcoming KDE SC 4.7

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102010/#review4861
-----------------------------------------------------------

Ship it!


Looks goot to me. (apart from those two minor details maybe ?)


src/rekonq.kcfg
<http://git.reviewboard.kde.org/r/102010/#comment4211>

    git commit -a ? I think you could push that typo fix in an unreviewed  micro-commit directly in master.



src/settings/generalwidget.cpp
<http://git.reviewboard.kde.org/r/102010/#comment4212>

    and maybe the "---..." can go ?


- Pierre


On July 19, 2011, 4:37 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102010/
> -----------------------------------------------------------
> 
> (Updated July 19, 2011, 4:37 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Title says it all. Easy and safe, I hope.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg dba770b 
>   src/settings/generalwidget.cpp 9f6de0d 
>   src/settings/settings_general.ui 0b27dab 
> 
> Diff: http://git.reviewboard.kde.org/r/102010/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110719/77b77bb1/attachment.htm