[rekonq] Re: Review Request: This is JuniorJob about doing better Tab Previews

[Vyacheslav Blinov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101848/
-----------------------------------------------------------

(Updated July 11, 2011, 10:13 a.m.)


Review request for rekonq.


Changes
-------

Thanks for your review, I really appreciate that you point me on my mistakes and give me possibilities to learn.
This is what was improved since last review:

* removed trailing spaces
* used "m_" prefix to show member variables
* used class's initialization list
* fixed intendation
* removed unneeded QWidget that was used as view
* fixed "magic number", now preview generated using actual browser window's sizing (so preview pixmap is same size as actual browser's page shown in tab)
* moved mask operations to resizing function

Johannes Tröscher:
I didn't changed scope of consts since I belive that they are specific to this class and not to global scope, I prefer to keep global scope clean for things that are really global.

Andrea Diamantini:
Isn't plasma transparency didn't works without compositing? Of course it can be made to be transparent without compositing, but it will be resource consuming (comparing to compositing solution) and slow on not so modern pc's where compositing usually can't be enabled cause of legacy video adapter. Anyway with compositing disabled tab preview still shown, it's just not transparent.


Pierre Rossi:
I came to use current rekonq`s sizing cause it looks more naturally, and don't have problems with nvidia's twinview. You can blame me, but it looks good at any resolution and browser size, I've used. I know it can look not so well with very small browser window (e.g. 100x100), but imho no one browser can be usable with such a sizing.


Summary
-------

Improvements:

* title of the page is removed since it is visible on a tab.
* widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
* widget has rouned corners in all the styles
* url of the page is elided
* with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
* code of tab preview is now separated from tab bar so it is more explicit


Diffs (updated)
-----

  src/CMakeLists.txt db9506a 
  src/tabbar.h c1b0ba5 
  src/tabbar.cpp dee49ea 
  src/tabpreviewpopup.h PRE-CREATION 
  src/tabpreviewpopup.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101848/diff


Testing
-------

Tested with different styles: it still looks ok, without compositing transparency didn't works


Screenshots
-----------

sample of tab preview
  http://git.reviewboard.kde.org/r/101848/s/193/


Thanks,

Vyacheslav

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110711/f147253e/attachment.htm