[rekonq] Re: Review Request: GCI Task: Saving zoom settings for each web site

[Andrea Diamantini]

> On Jan. 25, 2011, 7:19 a.m., Furkan Üzümcü wrote:
> > There are empty lines with spaces and Can I ask why you don't use ReKonfig?

Sorry about the lines with space :)
Using rekonfig? Is it not clear in the code because I don't use it? Because the ReKonfig class does not let you use the config file in the same way I'm using it. Try applying patch, change some zoom settings on some sites and then check your rekonqrc file.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100207/#review1052
-----------------------------------------------------------


On Jan. 24, 2011, 11:02 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100207/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2011, 11:02 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Save zoom settings for each web site
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp b04c5e89f5ba4c24c58d2f28fc1fa74a106e4088 
>   src/webtab.cpp bac73fecb2001ecd32dffb62be517466d401b63f 
>   src/zoombar.h d45aab19afab40d4d4cc3eefcdf5b8a192f40fd1 
>   src/zoombar.cpp 55006b48396e4a16f326b9450ad10f7785af9abb 
> 
> Diff: http://git.reviewboard.kde.org/r/100207/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110126/7f87a46f/attachment.htm