[rekonq] Re: Review Request: GCI Task: Added support for entering link directly into the Favorites section in the New Tab Page
Furkan Üzümcü
furkanuzumcu at gmail.com
Tue Jan 25 08:45:02 CET 2011
> On Jan. 22, 2011, 5:06 p.m., Rohan Garg wrote:
> > Could you modify this patch to suit HIG and do it the way that was discussed in #kde-usability?
>
> Furkan Üzümcü wrote:
> I can't for 2 reasons.
> 1- I don't know what is discussed
> 2- I'm not on Arch Linux.
>
> So please, can somebody do it for me? I want this feature for the next release!
>
> Rohan Garg wrote:
> I dont see what Arch Linux has to do with this
>
> Furkan Üzümcü wrote:
> Well I'm using Windows Se7en now. I have neither KDE nor Linux.
>
> Andrea Diamantini wrote:
> I can ensure you all the things you need (qt, kdelibs, cmake, git, gcc and so on) are available also on Windows 7...
Please asnwer my question above.
- Furkan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100286/#review1029
-----------------------------------------------------------
On Jan. 18, 2011, 8:12 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100286/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2011, 8:12 p.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> Added support for entering link directly into the Favorites section in the New Tab .
> Preview selector bar shows up as you click on Add Favorites button.
>
>
> Diffs
> -----
>
> src/newtabpage.cpp 7dcc958
> src/previewselectorbar.h 9684a01
> src/previewselectorbar.cpp c8ab5b0
> src/websnap.cpp 54cf105
>
> Diff: http://git.reviewboard.kde.org/r/100286/diff
>
>
> Testing
> -------
>
> * Tested and works!
>
>
> Screenshots
> -----------
>
> Adding Favorites
> http://git.reviewboard.kde.org/r/100286/s/52/
>
>
> Thanks,
>
> Furkan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110125/ff3fe54f/attachment-0001.htm
More information about the rekonq
mailing list