[rekonq] Re: Review Request: Hide the new tab button when the tab bar is hidden, part 2

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100423/#review1000
-----------------------------------------------------------


That code was used when the button is on the right corner and has to go back to the position near the last tab. So your idea breaks that behavior.
I fixed adding a check on mainview.count().

- Andrea


On Jan. 18, 2011, 2:41 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100423/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2011, 2:41 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The new tab button still appears when you open a new window in rekonq and the tab  bar is hidden. I removed a line in updateTabButtonPosition which calls QToolButton::show, as it doesn't seem to be necessary but responsible for this bug.
> 
> Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq
> Branch: fixHideNewTabButton
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp cbe862f 
> 
> Diff: http://git.reviewboard.kde.org/r/100423/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110119/120a56ba/attachment.htm