[rekonq] Re: Review Request: GCI Task: Added support for entering link directly into the Favorites section in the New Tab Page

[Lionel Chauvin]

> On Jan. 17, 2011, 4:25 p.m., Andrea Diamantini wrote:
> > I like this, there is just one small thing to fix before merge. Or did you discuss something different in ml? I couldn't follow it..
> 
> Furkan Üzümcü wrote:
>     They talked about adding a button to the url bar like the add bookmark button. But nobody said anything about it in ml. I'm updating the patch.
> 
> Lionel Chauvin wrote:
>     I thought about reintroduce an "add bookmark" popup that allow to choose the bookmark folder and that propose to add this bookmark in the favorite too (with a checkbox).
> 
> Andrea Diamantini wrote:
>     I like that, Lionel. But I don't think it lets this be "unuseful". I'm for merging if you and ... (who implemented this?).. have no objections. Do you?

With this patch, what the user will do ?
He will open a tab, 
visit the website he want add as preview,
click on the new tab button, 
add a preview, 
click on the preview, 
go to the previous tab, 
copy the url, 
go the the new tab page, 
paste the url.
validate.

I think the feature of this patch were not needed if the previewselectorbar were global to all tabs like it was when Mathieu Gicquel introduced it.

With this workflow the user will:
open a tab, 
visit the website he want add as preview,
click on the new tab button, 
add a preview, 
click on the preview, 
go to the previous tab, 
validate.


- Lionel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100286/#review957
-----------------------------------------------------------


On Jan. 17, 2011, 5:11 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100286/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 5:11 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for entering link directly into the Favorites section in the New Tab .
> 
> 
> Diffs
> -----
> 
>   src/newtabpage.cpp 7dcc958 
>   src/previewselectorbar.h 9684a01 
>   src/previewselectorbar.cpp c8ab5b0 
>   src/websnap.h e5b550f 
>   src/websnap.cpp 54cf105 
> 
> Diff: http://git.reviewboard.kde.org/r/100286/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110117/5c17b4b5/attachment-0001.htm