[rekonq] Re: Review Request: GCI Task: Added support for entering link directly into the Favorites section in the New Tab Page
Lionel Chauvin
megabigbug at yahoo.fr
Mon Jan 17 17:37:38 CET 2011
> On Jan. 17, 2011, 4:25 p.m., Andrea Diamantini wrote:
> > I like this, there is just one small thing to fix before merge. Or did you discuss something different in ml? I couldn't follow it..
>
> Furkan Üzümcü wrote:
> They talked about adding a button to the url bar like the add bookmark button. But nobody said anything about it in ml. I'm updating the patch.
I thought about reintroduce an "add bookmark" popup that allow to choose the bookmark folder and that propose to add this bookmark in the favorite too (with a checkbox).
- Lionel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100286/#review957
-----------------------------------------------------------
On Jan. 16, 2011, 4:24 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100286/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2011, 4:24 p.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> Added support for entering link directly into the Favorites section in the New Tab .
>
>
> Diffs
> -----
>
> src/newtabpage.cpp 7dcc958
> src/previewselectorbar.h 9684a01
> src/previewselectorbar.cpp c8ab5b0
> src/websnap.h e5b550f
> src/websnap.cpp 54cf105
>
> Diff: http://git.reviewboard.kde.org/r/100286/diff
>
>
> Testing
> -------
>
> * Tested and works!
>
>
> Thanks,
>
> Furkan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110117/deff538a/attachment.htm
More information about the rekonq
mailing list