[rekonq] Re: Review Request: Save downloaded images of opensearch suggestions like websnaps

[Andrea Diamantini]

> On Jan. 17, 2011, 11:15 a.m., Andrea Diamantini wrote:
> > src/urlbar/listitem.cpp, line 402
> > <http://git.reviewboard.kde.org/r/100397/diff/1/?file=7142#file7142line402>
> >
> >     Should not we check if image exists, before?
> 
> Lionel Chauvin wrote:
>     It should not happen but I can remove the previous (hypothetical) pixmap if you want.

I was really thinking about the opposite. Why should we need to save another pixmap if we just have one? If you think instead that pixmap needs everytime to be updated, I have no more objections here and you can merge this code yourself or ask me to do it.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100397/#review943
-----------------------------------------------------------


On Jan. 15, 2011, 8:28 p.m., Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100397/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2011, 8:28 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Save downloaded images of opensearch suggestions like websnaps
> 
> 
> Diffs
> -----
> 
>   src/urlbar/listitem.h 30089ce 
>   src/urlbar/listitem.cpp f7514f2 
> 
> Diff: http://git.reviewboard.kde.org/r/100397/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110117/7441a1a6/attachment.htm