[rekonq] Re: Review Request: Changes to the context menu

Benjamin Poulain ikipou at gmail.com
Mon Jan 17 15:35:41 CET 2011



> On Jan. 17, 2011, 10:18 a.m., Andrea Diamantini wrote:
> > I'm not completely satisfied from this patch. Please, give people time to review code. In example, I'm a bit dubious about the use of the "showDeveloperTools" bit. Shouldn't we use the WebKit "developerExtras" flag instead?

Just trying to help. :(
If you want to review every patch I think that will not scale. Worse case we can just revert it.

I think it makes sense to have it separated from developerExtras because it aslo change the "view page source" action. At the moment, WebKit's developerExtras can be enabled in all cases in my opinion, so you can enable showDeveloperTools without having to reload all the pages.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100374/#review940
-----------------------------------------------------------


On Jan. 14, 2011, 10:08 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100374/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 10:08 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch contains the changes to the context menu which we decided in our meeting:
> 
> 1. Hide new tab entry if it is not necessary.
> 2. Print and Search action: I removed the print action. The search action is now in the "search with" submenu if some text is selected.
> 3. Hide the development menu entries and add an option to show them.
> 
> Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq
> Branch: meetingMenuChanges
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 7dfc186 
>   src/mainwindow.cpp 599295f 
>   src/rekonq.kcfg cda76d8 
>   src/settings/settings_webkit.ui 58fbe45 
>   src/webview.cpp 49fa103 
> 
> Diff: http://git.reviewboard.kde.org/r/100374/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110117/0111f180/attachment.htm 


More information about the rekonq mailing list