[rekonq] Re: Review Request: keep downloaded suggestions in memory

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100398/#review944
-----------------------------------------------------------



src/opensearch/opensearchengine.h
<http://git.reviewboard.kde.org/r/100398/#comment784>

    Could we change this name (or the other)? Having the same one when you are not really overriding it, is not good IMHO.


- Andrea


On Jan. 16, 2011, 4:01 p.m., Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100398/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2011, 4:01 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> it is the first step of a cache system for suggestions.
> keep downloaded suggestions in memory.
> prevent downloaded it again.
> the completion list is more reactive.
> 
> 
> Diffs
> -----
> 
>   src/opensearch/opensearchengine.h c05501f 
>   src/opensearch/opensearchengine.cpp ef0f3f7 
>   src/opensearch/opensearchmanager.cpp 41e46ec 
> 
> Diff: http://git.reviewboard.kde.org/r/100398/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110117/552fd9b1/attachment.htm