[rekonq] Re: Review Request: Changes to the context menu

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100374/#review897
-----------------------------------------------------------

Ship it!



src/webview.cpp
<http://git.reviewboard.kde.org/r/100374/#comment761>

    Maybe "On current page"?
    "On Current Site" could be a google search on current domain for example.
    
    Note that English capitalize the first letter of each words for menus. I have no idea where this silly convention comes from.


Looks good, r+.
Just fix the text and push.

- Benjamin


On Jan. 14, 2011, 10:08 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100374/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 10:08 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch contains the changes to the context menu which we decided in our meeting:
> 
> 1. Hide new tab entry if it is not necessary.
> 2. Print and Search action: I removed the print action. The search action is now in the "search with" submenu if some text is selected.
> 3. Hide the development menu entries and add an option to show them.
> 
> Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq
> Branch: meetingMenuChanges
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 7dfc186 
>   src/mainwindow.cpp 599295f 
>   src/rekonq.kcfg cda76d8 
>   src/settings/settings_webkit.ui 58fbe45 
>   src/webview.cpp 49fa103 
> 
> Diff: http://git.reviewboard.kde.org/r/100374/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110114/4ea6eee2/attachment.htm