[rekonq] Re: Review Request: GCI Task: Limit the entries in the "Closed Tabs" right-click context menu

[Furkan Üzümcü]

> On Jan. 11, 2011, 5:10 p.m., Andrea Diamantini wrote:
> > I don't think this really solves the situation. You should probably limit the "recentlyClosedTabs" list, instead.

Isn't it used for the closed tabs section on New Tab Page?
If so people might want to get more closed tabs from there.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100315/#review836
-----------------------------------------------------------


On Jan. 7, 2011, 8:29 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100315/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2011, 8:29 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> After a lon rekonq session, you often have closed *a lot* of tabs. If you then
> accidentaly closed a tab and you want to open it up, rekonq will freeze, while
> the Closed Tabs context menu is loading. This is due to the many entries in
> that menu. 
> Limiting the menu to 10 entries would make the situation better.
> This also probably would solve the memory leak, that probably is caused by the
> context menu.
> 
> If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
> rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
> 
> https://bugs.kde.org/show_bug.cgi?id=240356
> 
> 
> Diffs
> -----
> 
>   src/tabbar.cpp 286d7d4 
> 
> Diff: http://git.reviewboard.kde.org/r/100315/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110111/15451089/attachment.htm