[rekonq] Re: Review Request: GCI Task: Expand grouped search results in history by default

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100310/#review798
-----------------------------------------------------------


The patch seems good and I'm going to merge it. But... did you notice you changed also bookmarks panel behavior? Is this silently intended?

Second, the "tested and works" string you add to the testing done is completely unuseful. If your feature does not compile, and if you didn't test it, why did you ask for a review/merge request? There you have to write WHAT you do to test it. Unit tests? Static tests? Manual tests? etc...

- Andrea


On Jan. 8, 2011, 12:14 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100310/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 12:14 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for automatically expanding the grouped search results in history panel by default.
> 
> 
> Diffs
> -----
> 
>   src/urlpanel.h 42ff85f 
>   src/urlpanel.cpp d7ddd89 
> 
> Diff: http://git.reviewboard.kde.org/r/100310/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110109/7913be06/attachment.htm