[rekonq] Re: Review Request: GCI Taks: Added support for pinning tabs

[Jon Ander Peñalba]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100305/#review778
-----------------------------------------------------------


Works for me (I had to merge it a few commits before master though).
The only problem I notice is that the tabs wont remember their status. If you pin a tab, close it and then open recently closed tabs it wont be pinned. I think that would be a really nice addition.

- Jon Ander


On Jan. 7, 2011, 5:21 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100305/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2011, 5:21 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for pinning tabs like Firefox 4 and Google Chrome.
> The default preview size was discussed on IRC.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 466a0a4 
>   src/mainview.h bc8b676 
>   src/mainview.cpp 42a7675 
>   src/rekonq.kcfg cda76d8 
>   src/tabbar.h 4170786 
>   src/tabbar.cpp 5712497 
> 
> Diff: http://git.reviewboard.kde.org/r/100305/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/2e8d149d/attachment.htm