[rekonq] Re: Review Request: Add a tab list menu to the corner widget

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100253/
-----------------------------------------------------------

(Updated 2011-01-08 00:18:47.756970)


Review request for rekonq.


Changes
-------

Rebased and some small changes.

About your points, Benjamin:
1. I can't check this with the cornerWidget size as I don't know if both buttons are in the widget or only one. Anyway, this cornerwidget should have its minimum size all the time anyway and I never heard of a style that shows layouts, so I don't see a reason to change it.
2. No, why? It first detects if the addNewTabButton should be in the corner widget and then it checks if it's already in it. It would get really complicated if I make it the other way around.
3. This is needed because the newTabButton has a smaller size after it was in the cornerWidget once.
4.+5. I don't know what this code is for, it was there already. I removed the lines and found nothing that has changed, so they stay removed
6.+7. done 


Summary
-------

This patch adds a tool button to the corner widget of the tab widget which shows a list of the current open tabs. In contrast to the open new tab button this button is always in the top right edge.

If you don't like to download the patch, you can also use my git clone on github:
Clone: git://github.com/Fxrh/rekonq.git
Branch: tabListButton


Diffs (updated)
-----

  src/mainview.h bc8b676 
  src/mainview.cpp 42a7675 

Diff: http://git.reviewboard.kde.org/r/100253/diff


Testing
-------

Tested and works well.


Thanks,

Felix

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/00f78ee5/attachment.htm