[rekonq] Re: Review Request: GCI Task: Fix the “Open Folder in Tabs” feature

[Benjamin Poulain]

> On 2011-01-07 22:48:10, Benjamin Poulain wrote:
> > This was correct at 25f7a9dc17f047715db0a06729151f8721513800 (9 oct), note there the code was
> >     if (bookmark.isGroup())
> >         openFolderinTabs(bookmark.toGroup());
> > 
> > Then broken with bd32f05dab4832528e0c2304d722e5140ffd74e4.
> > 
> > Please check if it is possible to invoke this slots with bookmark.isGroup() == true. If yes, add the if, if not, add an ASSERT.

I meant bookmark.isGroup() == false, in which case the call to KBookmarkGroup::toGroup() would be invalid...


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100318/#review765
-----------------------------------------------------------


On 2011-01-07 22:39:51, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100318/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 22:39:51)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fixed the "Open Folder in Tabs" feature.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkowner.h 4d37719 
>   src/bookmarks/bookmarkowner.cpp c684897 
> 
> Diff: http://git.reviewboard.kde.org/r/100318/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110107/c129d8fd/attachment.htm