[rekonq] Re: Review Request: A bit of cleanup in Application.
Benjamin Poulain
ikipou at gmail.com
Fri Jan 7 22:31:56 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100316/#review762
-----------------------------------------------------------
Ship it!
Really cool. I like when a cleaning patch have more - than + :)
- Benjamin
On 2011-01-07 21:17:27, Pierre Rossi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100316/
> -----------------------------------------------------------
>
> (Updated 2011-01-07 21:17:27)
>
>
> Review request for rekonq and Benjamin Poulain.
>
>
> Summary
> -------
>
> I believe we don't need static members in QWeakPointers for all the *Managers, static getter functions would do the job.
>
>
> This addresses bug N/A.
> /show_bug.cgi?id=N/A
>
>
> Diffs
> -----
>
> src/application.h b30e337
> src/application.cpp 466a0a4
>
> Diff: http://git.reviewboard.kde.org/r/100316/diff
>
>
> Testing
> -------
>
> "compiles and runs" ™
>
>
> Thanks,
>
> Pierre
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110107/c8c9eb35/attachment.htm
More information about the rekonq
mailing list