[rekonq] Re: Review Request: GCI Task: Prevent Rekonq from showing multi scroll button when middle click on scrollbars

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100276/#review748
-----------------------------------------------------------

Ship it!



src/webview.cpp
<http://git.reviewboard.kde.org/r/100276/#comment563>

    Coding style:
    Space missing between the if and the parenthesis.
    The opening bracket should be on the same line as the if().


The patch's logic looks correct. Fix the coding style and put a better commit message and it is all good to me.

- Benjamin


On 2010-12-31 17:24:17, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100276/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 17:24:17)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The "multiscroll" doesn't get toggled when hovering over the scrollbar.
> (Rekonq Wish >> https://bugs.kde.org/show_bug.cgi?id=234888)
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp 2c0b59e 
> 
> Diff: http://git.reviewboard.kde.org/r/100276/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110106/90509652/attachment.htm