[rekonq] Re: Review Request: GCI Task: Open multiple selected text links in new tabs

[Pierre Rossi]

> On 2011-01-05 10:32:56, Jon Ander Peñalba wrote:
> > I would like to have the option of opening all the links in the selected text in new tabs, but I don't like how this patch implements it.
> > 
> > This patch only takes into account the text (if it starts with http://, https:// or www. it's a link), it doesn't look for actual links, and if they are both present this is not at all intuitive.
> > I would like to see this working only with actual links or not implemented at all.

I would tend to agree with this: I believe actual links are more important than text that seems to be a valid url, and links will most likely not have http:// in their text. The problem is that there is no nice API in QtWebKit to to that at the moment, and using the selection and ranges in Javascript requires Javascript to be enabled, which we can't guarantee.

Andrea has a point in his comment from December 17th: do we really need this ? As a side note: since a Javascript approach would work, this could be done quite simply via a bookmarklet.


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100215/#review740
-----------------------------------------------------------


On 2010-12-17 17:12:32, Panagiotis Papadopoulos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100215/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 17:12:32)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When you select an area of text on the page that contains more than one link,
> it would be very useful if you were given a right-click option to open those
> links in new tabs.  This is a very useful feature in firefox.  An option to
> open them in a single new window would also be nice, although not important
> since it is easy enough to detach the tab first.
> 
> Taken from the Wish on bko
> 
> Patch by Andrzej G?owi?ski 
> 
> 
> This addresses bug 248863.
>     /show_bug.cgi?id=248863
> 
> 
> Diffs
> -----
> 
>   src/webview.h 9518b74 
>   src/webview.cpp aeaf92b 
> 
> Diff: http://git.reviewboard.kde.org/r/100215/diff
> 
> 
> Testing
> -------
> 
> works here
> 
> 
> Thanks,
> 
> Panagiotis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110106/1734606f/attachment.htm