[rekonq] Re: Review Request: Adding the feature to Open with Preferred application and Open with options

[Jon Ander Peñalba]

> On 2010-11-24 23:14:57, Andrea Diamantini wrote:
> > oops... I finally spent a couple of minutes downloading your patch and really testing it. I don't think we can really apply it as this completely breaks rekonq feature of embedding parts. IMHO, this is a no-go.
> 
> Jon Ander Peñalba wrote:
>     What about a settings option to allow the user to select if he prefers to embed the files or to open them in another application?
>     The other option is to have both in the same dialog. If you look at the BrowserOpenOrSaveQuestion class you can see this: "// TODO askOpenEmbedOrSave". We might be able to implement it ourself.
>     
>     I would like to have the option to open files in external applications, but I agree that embedding parts is more important so it can't be implemented if they break.
> 
> Andrea Diamantini wrote:
>     I think the think Jon is talking about is a completely different feature from the one implemented here (so that this request should be closed).
>     About Jon's request.. the settings option should be quite easy and fast to implement, while the second one is not "canonical" and IMHO more complicated.

It's not a completely different thing. What I mean is giving the user the option to choose between the current functionality or the one added by this patch.


- Jon Ander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100164/#review397
-----------------------------------------------------------


On 2010-11-22 19:31:36, Chinmaya Padhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100164/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 19:31:36)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Adding the feature of Open with Preferred Application and Open With options , while clicked on a file . 
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp 2347b6d 
> 
> Diff: http://git.reviewboard.kde.org/r/100164/diff
> 
> 
> Testing
> -------
> 
> Tested on various files by clicking on them and opening them in the preferred application. It works fine .
> 
> 
> Thanks,
> 
> Chinmaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110105/44a24288/attachment.htm