[rekonq] Re: Review Request: Escape Button stops a loading page

Furkan Üzümcü furkanuzumcu at gmail.com
Sat Feb 19 20:08:16 CET 2011



> On Feb. 19, 2011, 6:58 p.m., Benjamin Poulain wrote:
> > src/mainview.cpp, lines 208-212
> > <http://git.reviewboard.kde.org/r/100661/diff/4/?file=9410#file9410line208>
> >
> >     This is a strange call site for this. Not to mention MainView::webStop() does not do anything if currentUrlBar()->completionBox().data()->isVisible(), this is really counter-intuitive.

It's not supposed to do anyway. I searched for that slot in the whole project and it's only used by the action. Even if it's used in somewhere later it's going to break anything because if the completionBox isn't visible it'll do its job other wise first hide the widget and then stop the loading.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100661/#review1514
-----------------------------------------------------------


On Feb. 17, 2011, 7:10 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100661/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2011, 7:10 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The issue is solved by changing the webStop() function in mainView. That function is only used by the stop action.
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp dfa202d 
>   src/mainwindow.cpp 24dc865 
>   src/urlbar/urlbar.h 964534c 
> 
> Diff: http://git.reviewboard.kde.org/r/100661/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110219/c11494a0/attachment.htm 


More information about the rekonq mailing list