[rekonq] Re: Review Request: Escape Button stops a loading page

[Furkan Üzümcü]

> On Feb. 19, 2011, 6:57 p.m., Andrea Diamantini wrote:
> > Again, what about zoombar and findbar?
> > They have to be hided with ESC button. Did you check your code does NOT break those?

I did. The what ESC button does for the zoombar and finbar is handled in the event function in MainWindow. What I do is to change the slot that the action uses. So it doesn't break.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100661/#review1513
-----------------------------------------------------------


On Feb. 17, 2011, 7:10 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100661/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2011, 7:10 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The issue is solved by changing the webStop() function in mainView. That function is only used by the stop action.
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp dfa202d 
>   src/mainwindow.cpp 24dc865 
>   src/urlbar/urlbar.h 964534c 
> 
> Diff: http://git.reviewboard.kde.org/r/100661/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110219/1ab31b88/attachment-0001.htm